[wp-trac] [WordPress Trac] #46650: Site Health: heading misaligned when Hello Dolly is active
WordPress Trac
noreply at wordpress.org
Tue Mar 26 09:12:50 UTC 2019
#46650: Site Health: heading misaligned when Hello Dolly is active
-----------------------------------------+------------------------------
Reporter: afercia | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Administration | Version: trunk
Severity: normal | Resolution:
Keywords: has-screenshots site-health | Focuses:
-----------------------------------------+------------------------------
Comment (by xkon):
I've added a test notice just to see what happens as @afercia mentioned
and sharing a screenshot of what I see at least.
I have never seen how notices work actually so I did some research finding
that the notices are going after `.wrap h1, .wrap h2` ( found this in
common.js so correct me if I'm wrong ).
Would it be a bold move especially at this point to think of adding a
"custom" placeholder as well for the notices to spawn at instead of the
first available h1/h2 within wrap? This isn't related to Site Health in
specific but a broader thinking of how it currently works as it seems way
to restrictive.
Not really sure if adding an extra empty wrap/h1 above the Site Health
wrapper be ok as well just to move the notices on a better spot as an
empty h1 might lead into other issues.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46650#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list