[wp-trac] [WordPress Trac] #46647: Site Health: Improve the "Copy to Clipboard" button
WordPress Trac
noreply at wordpress.org
Tue Mar 26 00:15:18 UTC 2019
#46647: Site Health: Improve the "Copy to Clipboard" button
-------------------------------------------------+-------------------------
Reporter: pento | Owner: pento
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.2
Component: Administration | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots needs- | Focuses:
design-feedback | accessibility
-------------------------------------------------+-------------------------
Changes (by pento):
* keywords: => has-patch has-screenshots needs-design-feedback
Comment:
In [attachment:"46647.diff"]:
- Introduce [https://clipboardjs.com/ clipboard.js], which the block
editor also uses for managing cross-browser clipboard handling.
- Remove the hidden `<textarea>` elements.
- Change the copy button label to "Copy report to clipboard".
- Rename `WP_Debug_Data::textarea_format()` to `WP_Debug_Data::format()`,
and make it return the formatted data, instead of printing it.
- Cleaned up the class names in the copy button section.
@hedgefield: Just looking at the clipboard button section, what are your
thoughts on how it's implemented? In particular, one of the concerns is
that it isn't clear what's being copied: does the button label help with
that, or can we point it out in a clearer way?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46647#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list