[wp-trac] [WordPress Trac] #38874: Change include of "includes/plugin-install.php" to include_once

[WordPress Trac]

#38874: Change include of "includes/plugin-install.php" to include_once
-------------------------------------+-----------------------------
 Reporter:  engelen                  |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  5.3
Component:  Plugins                  |     Version:  3.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  administration
-------------------------------------+-----------------------------
Changes (by desrosj):

 * keywords:   => has-patch needs-testing
 * version:  4.6.1 => 3.1
 * milestone:  Awaiting Review => 5.3


Comment:

 Hi @engelen,

 First off, sorry that it took so long or someone to get back to you on
 this.

 I've done some digging to connect the dots on some history. For reference,
 here is what I found:

 - The `include_once` in `wp-admin/includes/ajax-actions.php` was
 introduced in [37714] for version 4.6.
 - The `include` in `wp-admin/includes/class-wp-plugin-install-list-
 table.php` was introduced in [15491] for version 3.1.
 - The `require_once` in `wp-admin/update-core.php` was introduced in
 [12157] for version 2.9.
 - The `include_once` in `wp-admin/update.php` was introduced in [11005]
 for version 2.8 (formatting modified in [28500]).

 The patch still applies for me, and this makes sense. I am going to
 milestone this for the next release to get it some attention, testing, and
 feedback.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38874#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform