[wp-trac] [WordPress Trac] #46640: Classic Editor: the distraction-free button breaks keyboard navigation

[WordPress Trac]

#46640: Classic Editor: the distraction-free button breaks keyboard navigation
---------------------------------------+------------------------------
 Reporter:  afercia                    |       Owner:  (none)
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  Awaiting Review
Component:  Editor                     |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  accessibility
---------------------------------------+------------------------------
Changes (by afercia):

 * keywords:  has-screenshots => has-screenshots has-patch


Comment:

 [attachment:"46640.diff"] :

 - keeps the button visible
 - makes the DOM order match the visual order

 Also, while looking into this, I've noticed this couple lines related to
 backwards compatibility for the old distraction free mode:
 https://core.trac.wordpress.org/browser/trunk/src/wp-includes/script-
 loader.php?rev=44986&marks=927-928#L926


 {{{
 // Back-compat for old DFW. To-do: remove at the end of 2016.
 $scripts->add( 'wp-fullscreen-stub', "/wp-admin/js/wp-fullscreen-
 stub$suffix.js", array(), false, 1 );
 }}}

 Maybe worth considering for removal. /Cc @azaozz

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46640#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform