[wp-trac] [WordPress Trac] #46098: Help notice displayed on Privacy Policy page missing in block editor

[WordPress Trac]

#46098: Help notice displayed on Privacy Policy page missing in block editor
-------------------------------------+------------------------------
 Reporter:  aduth                    |       Owner:  garrett-eclipse
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.2
Component:  Privacy                  |     Version:  5.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  administration
-------------------------------------+------------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch needs-refresh => has-patch needs-testing
 * owner:  (none) => garrett-eclipse
 * status:  new => assigned
 * milestone:  Future Release => 5.2


Comment:

 Thanks @aduth and @Joen for your work on the block editor notices.

 I've updated @aduth's original patch as follows;
 - Preserved the classic editor notice.
 - Updated the classic editor notice to use the same message, url and label
 as the block editor notice. This change moves the link after the message
 into a link. This link keeps the translator comments and the accessibility
 '(opens in a new tab)' screen reader text.
 - Updates the block editor notice to use the same message, url and label
 as well as disabled the dismissable functionality.
 - The label used in both cases is 'View Privacy Policy Guide.'
 - The url used in both cases is escaped with esc_url

 This accounts for the discussion feedback and avoids the need for
 `__unstableHTML` while keeping both versions of the notice consistent.

 As well with the dismissable removed from the block editor notice the X no
 longer overlaps as well it doesn't stick so shouldn't overlap block editor
 toolbars.

 Moving this into 5.2 for review and testing.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46098#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform