[wp-trac] [WordPress Trac] #46599: Replace compatibility tests with new functions

[WordPress Trac]

#46599: Replace compatibility tests with new functions
------------------------------------------------+--------------------------
 Reporter:  afragen                             |       Owner:
                                                |  SergeyBiryukov
     Type:  defect (bug)                        |      Status:  reviewing
 Priority:  normal                              |   Milestone:  5.2
Component:  Plugins                             |     Version:
 Severity:  normal                              |  Resolution:
 Keywords:  servehappy has-patch needs-testing  |     Focuses:
------------------------------------------------+--------------------------

Comment (by afragen):

 If we wish to keep the empty checks I would propose adding an additional
 test to ensure the variable is set to something. The empty test in the
 original was to allow for a plugin that didn’t have a header set to be
 valid.

 It appears that this commit will stop any plugin that doesn’t have one of
 the `readme.txt` headers defined to fail. I’m not at my computer today so
 I can’t test. I would much rather see this reverted and figure out a
 better name in beta.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46599#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform