[wp-trac] [WordPress Trac] #36860: Introduce filter for users_have_content within delete action of users.php
WordPress Trac
noreply at wordpress.org
Thu Mar 21 08:28:30 UTC 2019
#36860: Introduce filter for users_have_content within delete action of users.php
--------------------------------------------+------------------------------
Reporter: garrett-eclipse | Owner: garrett-eclipse
Type: enhancement | Status: accepted
Priority: normal | Milestone: 5.2
Component: Users | Version: 4.6
Severity: normal | Resolution:
Keywords: has-patch needs-testing commit | Focuses: administration
--------------------------------------------+------------------------------
Changes (by garrett-eclipse):
* keywords: has-patch needs-testing 2nd-opinion dev-feedback => has-patch
needs-testing commit
Comment:
Thanks @xkon & @birgire I greatly appreciate the testing and input. And
whole-heartedly agree that differentiating the filter by naming it
`users_have_additional_content` gives it the necessary context to properly
define it's behaviour.
I also appreciate the additional patches and have put a final
[https://core.trac.wordpress.org/attachment/ticket/36860/36860.7.diff
36860.7.diff] forward which removes the need for the additional variable
and checks as it provides the same results/conditions and preserves the
distinct and contextual filter name.
I've marked as commit, but please take a last test on it and I'll work on
the docs once it's in the 5.2 beta.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36860#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list