[wp-trac] [WordPress Trac] #46312: Replace http with https in custom links menu item
WordPress Trac
noreply at wordpress.org
Thu Mar 21 02:46:09 UTC 2019
#46312: Replace http with https in custom links menu item
-----------------------------------------+-----------------------
Reporter: aksl95 | Owner: audrasjb
Type: enhancement | Status: accepted
Priority: normal | Milestone: 5.2
Component: Menus | Version:
Severity: normal | Resolution:
Keywords: has-screenshots needs-patch | Focuses:
-----------------------------------------+-----------------------
Changes (by celloexpressions):
* keywords: has-patch has-screenshots commit => has-screenshots needs-
patch
Comment:
The (original) design intent of this "placeholder" is actually to be a
part of a value as opposed to a true placeholder. It's provided as a
staring point for users that type in a URL. Users pasting in a URL would
need to manually remove this default value. I'd prefer keeping the current
behavior unless research supports making a change. However, I support
updating to `https://` either way. I also recall some menu customizer JS
that may be tied to the default value and that should be confirmed before
making the change.
This needs to be updated both in the customizer and in the admin version
of menus if a change is made, either way. It looks like we need a
combination of [attachment:"46312.2.diff"] and [attachment:46312-patch-
https.diff] once a decision is made on changing from a default value to a
placeholder.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46312#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list