[wp-trac] [WordPress Trac] #46573: Introduce a Site Health module for users to self-service their site

[WordPress Trac]

#46573: Introduce a Site Health module for users to self-service their site
---------------------------------------+---------------------
 Reporter:  Clorith                    |       Owner:  (none)
     Type:  enhancement                |      Status:  new
 Priority:  normal                     |   Milestone:  5.2
Component:  General                    |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:
---------------------------------------+---------------------

Comment (by xkon):

 Awesome @Clorith thanks for that! The site-health-info.php needs also
 updating to it's links towards site-health.php as well :). They currently
 link back to the "original" 2 pages so the menu is getting lost again ( to
 replicate go into the Info tab and then click Status again ).

 As we've talked on slack ( mentioning here so it won't be misunderstood
 also ), I'll be going through files mentioning things that I see so you
 can get patches up since this is quite big and there's no need for
 multiple hands to go over these files for now to keep it as clean as
 possible.

 Here goes round 1 ! haha Extra things that I currently see in the patch (
 I'll also ask in most cases as I go through each file so haven't looked
 the overall codebase ):

 `general things`

 `require_once` some parts of core use it with `()` some others not, not
 really sure what's the way here I'm a bit confused as it shouldn't have
 imho.

 static calls within the same class, could we use `self::` instead? i.e.
 `class-wp-site-health.php - Line 90`, again not sure what's the proper way
 according to what's generally used.

 `site-info-health.php`

 Line 20 uses spaces instead of tabs.

 Lines 39 to 55 use spaces instead of tabs.

 Line 161 the `$values` should be escaped?

 `site-health.php`

 Lines 10 & 11 spaces instead of tabs.

 `class-wp-site-health.php`

 Lines 16, 17 & 18 those `=` could get aligned

 Line 90 ( mentioned above for self:: )

 Line 170 `$_POST['feature']` should be sanitized?

 Lines 307, 574 & 970 comment is missing a `.` :D

 Lines 1427 & 1427 `sizeof` should be `count` instead ?

 We need doc blocks definitely here as pretty much all functions as I see
 don't have one but can be done in smaller patches etc.

 --

 I'll be taking looks as much as possible on newer patches as well to at
 least help this way for now :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46573#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform