[wp-trac] [WordPress Trac] #44350: Block plugin updates if required PHP version is not supported - Updates screen
WordPress Trac
noreply at wordpress.org
Wed Mar 20 02:44:33 UTC 2019
#44350: Block plugin updates if required PHP version is not supported - Updates
screen
-------------------------------------------------+-------------------------
Reporter: flixos90 | Owner: afragen
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 5.2
Component: Plugins | Version:
Severity: normal | Resolution:
Keywords: needs-unit-tests servehappy has- | Focuses:
patch needs-testing |
-------------------------------------------------+-------------------------
Changes (by desrosj):
* keywords: needs-unit-tests servehappy dev-feedback has-patch => needs-
unit-tests servehappy has-patch needs-testing
Comment:
In [attachment:"44350.13.diff"]:
- It seems like the closing `<p>` is not needed when displaying the
annotation here. Also, the `.description` class was causing light gray
text on white, which was not good for a11y. Changing to a `<span
class="description">` fixes the mismatched HTML and the contrast issues.
- I removed the added output escaping. The `$plugin_data` variable is
populated by `_get_plugin_data_markup_translate()`, which passes each
value through `wp_kses()` with a list of allowed tags for that attribute.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44350#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list