[wp-trac] [WordPress Trac] #43987: Block plugin updates if required PHP version is not supported - Plugins screen

[WordPress Trac]

#43987: Block plugin updates if required PHP version is not supported - Plugins
screen
-------------------------------------------------+-------------------------
 Reporter:  schlessera                           |       Owner:  afragen
     Type:  task (blessed)                       |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.2
Component:  Plugins                              |     Version:  5.1
 Severity:  normal                               |  Resolution:
 Keywords:  needs-unit-tests servehappy has-     |     Focuses:
  patch dev-feedback commit                      |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  needs-unit-tests servehappy has-patch dev-feedback => needs-
     unit-tests servehappy has-patch dev-feedback commit


Comment:

 [attachment:"43987.2.diff"] removes the `esc_attr()` wrappers for
 `$plugin_name` that were added. `$plugin_name` is passed through
 `wp_kses()` further up to strip out harmful markup, and the parts of the
 string being output in attributes are already escaping. Passing
 `$response->new_version` through `esc_attr()` seems ok, though.

 I think we can improve how the annotation is displayed a bit, but this
 looks good for beta.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43987#comment:38>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform