[wp-trac] [WordPress Trac] #43438: Add filters and Ajax support for personal data export
WordPress Trac
noreply at wordpress.org
Tue Mar 19 23:18:02 UTC 2019
#43438: Add filters and Ajax support for personal data export
-------------------------------------------------+-------------------------
Reporter: azaozz | Owner: desrosj
Type: enhancement | Status: reopened
Priority: low | Milestone: 5.2
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: has-unit-tests has-patch needs- | Focuses:
testing |
-------------------------------------------------+-------------------------
Comment (by garrett-eclipse):
Nice @davidbinda good catch. I ran the test before patching to see what I
was dealing with and got 1 error and 46 failures with 42 of them being in
the privacy component. Applying your patch and retesting I still have the
1 error but only 4 failures and none within privacy. That's awesome, thank
you.
That error and failures will be dealt with in #46567 that @desrosj opened
there, so I posted the remaining error and failures there.
As to the refreshed patch I just uploaded
[https://core.trac.wordpress.org/attachment/ticket/43438/43438.21.diff
43438.21.diff]. It simply switches from the unnecessary yoda conditionals
to just check is_multisite() which follows the current convention in core.
*Also there was a minor spaces instead of tabs thing which is also
corrected.
Cheers
P.S. @desrosj this is good to commit in my opinion but I left in `needs-
testing` so you can give it a once through.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43438#comment:94>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list