[wp-trac] [WordPress Trac] #44901: Remove unneeded WP_Error in confirmaction

WordPress Trac noreply at wordpress.org
Tue Mar 19 02:37:45 UTC 2019


#44901: Remove unneeded WP_Error in confirmaction
------------------------------+------------------------------
 Reporter:  garrett-eclipse   |       Owner:  garrett-eclipse
     Type:  enhancement       |      Status:  closed
 Priority:  normal            |   Milestone:  5.2
Component:  Privacy           |     Version:  4.9.6
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:
------------------------------+------------------------------
Changes (by desrosj):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"44931" 44931]:
 {{{
 #!CommitTicketReference repository="" revision="44931"
 Privacy: Remove unnecessary `WP_Error` when handling `confirmaction`
 requests.

 By reordering the logic when handling the `confirmaction` action in `wp-
 login.php`, the need for a new `WP_Error` object to be created can be
 eliminated. The error message can be passed directly into a `wp_die()`
 call, matching the other validation errors in related code.

 Props garrett-eclipse, birgire.
 Fixes #44901.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44901#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list