[wp-trac] [WordPress Trac] #41074: Create new Dashicons (4.9-5.2) (was: Create new Dashicons (4.9))

[WordPress Trac]

#41074: Create new Dashicons (4.9-5.2)
-------------------------------------------------+-------------------------
 Reporter:  EmpireOfLight                        |       Owner:  netweb
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.2
Component:  Administration                       |     Version:  4.9
 Severity:  normal                               |  Resolution:
 Keywords:  needs-dev-note needs-refresh has-    |     Focuses:  ui
  patch                                          |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  needs-dev-note reporter-feedback needs-refresh has-patch =>
     needs-dev-note needs-refresh has-patch


Comment:

 @JeffPaul Happy to own this. I can commit the changes after the items I
 listed above are addressed.

 @folletto I think that was the previous practice, but the Gutenberg
 feature focus caused this one to be punted repeatedly. I have adjusted the
 ticket title to indicate this addition spanned multiple releases. I have
 some ideas to make this process go more smoothly that I'll be brain
 dumping and experimenting with after 5.2 beta 1 this week. If you'd like,
 let's connect separately!

 The Instagram icon
 [https://github.com/WordPress/dashicons/commit/8ebc2cfb284d14d6286ef50e1996170ee585ea6c
 has been fixed upstream].

 That leaves the missing `plus-alt2` and the `share1` icons as the last two
 items to resolve.

 I have [https://github.com/WordPress/dashicons/pull/346 opened a PR to re-
 add the `share1` icon]. I was incorrect in my previous assessment that
 this icon was never shipped with core, so this should be re-added.

 I believe that the reason the `plus-alt2` icon is not being included in
 the build is being caused by the lack of an SVG file in the `sources/svg`
 folder. If someone can create an SVG file for this icon, a PR can be
 opened to re-add it to the built files. For reference, this is the
 `<glyph>` included in the current version of the `dashicons.svg` sprite:


 {{{
 <glyph unicode="&#xf543;" d="M1700 1100v-200h-600v-600h-200v600h-
 600v200h600v600h200v-600h600z" />
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41074#comment:96>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform