[wp-trac] [WordPress Trac] #42057: Add ability to pass a label for the <form> element returned by get_search_form()

WordPress Trac noreply at wordpress.org
Mon Mar 18 13:15:09 UTC 2019


#42057: Add ability to pass a label for the <form> element returned by
get_search_form()
------------------------------------+-----------------------------
 Reporter:  williampatton           |       Owner:  SergeyBiryukov
     Type:  enhancement             |      Status:  reviewing
 Priority:  normal                  |   Milestone:  5.2
Component:  General                 |     Version:  4.8.2
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |     Focuses:  accessibility
------------------------------------+-----------------------------

Comment (by afercia):

 [attachment:"42057.4.diff"] updates a few things:
 - documentation
 - the `$args` arguments need to be documented
 - restored the `@return` tag
 - changed the `label` argument name to `aria_label` for clarity
 - the filtered `$args` array may not contain all the arguments so there's
 the need to check for them again

 A final review would be appreciated :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42057#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list