[wp-trac] [WordPress Trac] #46044: Add `wp_get_update_php_annotation()` to return the Update PHP annotation

WordPress Trac noreply at wordpress.org
Sun Mar 17 21:46:45 UTC 2019


#46044: Add `wp_get_update_php_annotation()` to return the Update PHP annotation
-----------------------------------------------+---------------------
 Reporter:  afragen                            |       Owner:  (none)
     Type:  defect (bug)                       |      Status:  new
 Priority:  normal                             |   Milestone:  5.2
Component:  Plugins                            |     Version:  5.1
 Severity:  normal                             |  Resolution:
 Keywords:  has-patch servehappy dev-feedback  |     Focuses:
-----------------------------------------------+---------------------

Comment (by TimothyBlynJacobs):

 The patch looks good to me. Right now its return type is really
 `string|null` but is annotated as `string`. Should the function either
 return an empty string when unnecessary, or should the doc be updated. I
 personally prefer returning an empty string, but that's just me.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46044#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list