[wp-trac] [WordPress Trac] #43632: Add a screen reader text for Hello Dolly lyrics

[WordPress Trac]

#43632: Add a screen reader text for Hello Dolly lyrics
---------------------------------------+----------------------------
 Reporter:  SergeyBiryukov             |       Owner:  audrasjb
     Type:  enhancement                |      Status:  assigned
 Priority:  normal                     |   Milestone:  5.2
Component:  Plugins                    |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  accessibility
---------------------------------------+----------------------------
Changes (by afercia):

 * keywords:  has-screenshots has-patch commit => has-screenshots has-patch


Comment:

 [attachment:"43632.8.diff"] updates a few things, more importantly:

 - removes the text domain for now **(pending confirmation)**
 - updates the plugin version, also in a related test
 - moves `lang="en"` to the lyrics because the part `Quote from Hello Dolly
 song, by Jerry Herman:` should be translated and pronounced in the
 translated language. Example (emulating translation in Italian):

 [[Image(http://cldup.com/ZravpoH65R.png)]]

 - makes the font size a bit bigger: 11px was really too small
 - simplifies the CSS so that only `float` needs to be reverted for RTL
 languages
 - adds a `dir="ltr"` to the lyrics: needed when in RTL especially for
 strings that end with an apostrophe
 - improves RTL on mobile


 Note: ideally, in the text:
 `Quote from Hello Dolly song, by Jerry Herman:`
 the parts `Hello Dolly` and `Jerry Herman` would need a `lang="en"`
 attribute because the song title and author name should be pronounced in
 English. However, for the sake of simplicity and to not add to many `lang`
 attributes, I'd lean towards keeping it as is.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43632#comment:45>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform