[wp-trac] [WordPress Trac] #44901: Remove unneeded WP_Error in confirmaction

[WordPress Trac]

#44901: Remove unneeded WP_Error in confirmaction
-----------------------------+------------------------------
 Reporter:  garrett-eclipse  |       Owner:  garrett-eclipse
     Type:  enhancement      |      Status:  accepted
 Priority:  normal           |   Milestone:  5.2
Component:  Privacy          |     Version:  4.9.6
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+------------------------------
Changes (by birgire):

 * keywords:  has-patch needs-testing => has-patch


Comment:

 Thanks @garrett-eclipse

 I did some more manual testing that worked as expected:

 Missing request_id:
 https://example.org/wp-
 login.php?action=confirmaction&confirm_key=QgaEc8mkBVXZZjvW0vLf
 Displays "Missing request ID." as expected.

 Missing confirm_key:
 https://example.org/wp-login.php?action=confirmaction&request_id=199
 Displays: "Missing confirm key." as expected.

 Missing both confirm_key and request_id:
 https://example.org/wp-login.php?action=confirmaction
 Displays: "Missing request ID." as expected.

 Missing confirmaction action:
 https://example.org/wp-
 login.php?request_id=199&confirm_key=QgaEc8mkBVXZZjvW0vLf
 Displays login screen as expected.

 Invalid confirm_key:
 https://example.org/wp-
 login.php?action=confirmaction&request_id=199&confirm_key=INVALID
 Displays: "Invalid key." as expected.

 Invalid request_id:
 https://example.org/wp-
 login.php?action=confirmaction&request_id=INVALID&confirm_key=QgaEc8mkBVXZZjvW0vLf
 https://example.org/wp-
 login.php?action=confirmaction&request_id=999999999999&confirm_key=QgaEc8mkBVXZZjvW0vLf
 Displays: "Invalid request." as expected.

 Valid export link:
 https://example.org/wp-
 login.php?action=confirmaction&request_id=199&confirm_key=QgaEc8mkBVXZZjvW0vLf
 Displays: "Thanks for confirming your export request." etc as expected.

 Try same export link again:
 https://example.org/wp-
 login.php?action=confirmaction&request_id=199&confirm_key=QgaEc8mkBVXZZjvW0vLf
 Displays: "This link has expired." as expected.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44901#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform