[wp-trac] [WordPress Trac] #46507: Grammar mistake in info comment

WordPress Trac noreply at wordpress.org
Fri Mar 15 23:53:19 UTC 2019


#46507: Grammar mistake in info comment
----------------------------+-----------------------------
 Reporter:  umang7          |       Owner:  SergeyBiryukov
     Type:  enhancement     |      Status:  reviewing
 Priority:  normal          |   Milestone:  5.2
Component:  Filesystem API  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  docs
----------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => reviewing
 * focuses:   => docs
 * component:  General => Filesystem API
 * milestone:  Awaiting Review => 5.2


Comment:

 Hi @umang7, welcome to WordPress Trac! Thanks for the patch.

 These files were initially an external library, however more than 20
 commits have been made to them over the years, so I don't see any reason
 not to fix this.

 While we're at it, let's also change `@since 2.5` to `@since 2.5.0`, per
 the [https://make.wordpress.org/core/handbook/best-practices/inline-
 documentation-standards/php/#since-section-changelogs documentation
 standards]. [26868] did this for `class-ftp-pure.php` and `class-ftp-
 sockets.php`, however `class-ftp.php` was missed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46507#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list