[wp-trac] [WordPress Trac] #46530: CSS line-height values should be unitless - media.css

[WordPress Trac]

#46530: CSS line-height values should be unitless - media.css
-------------------------------------+-------------------------------------
 Reporter:  ianbelanger              |      Owner:  ianbelanger
     Type:  defect (bug)             |     Status:  assigned
 Priority:  normal                   |  Milestone:  Awaiting Review
Component:  General                  |    Version:
 Severity:  normal                   |   Keywords:  has-patch needs-testing
  Focuses:  ui, administration,      |  good-first-bug
  coding-standards                   |
-------------------------------------+-------------------------------------
 As outlined in #44643, CSS line-height values should be unitless `unless
 necessary to be defined as a specific pixel value`. It was suggested that
 we break up 44643 by stylesheet in order to better track them.

 This ticket covers much of `wp-admin/css/media.css`, see patch notes below

 Note: The patch was tested only on a Windows machine in Chrome, Firefox,
 IE11 and Edge. As per
 https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably
 be tested on other OS's and supported browsers.

 **Patch Notes:**

 Unchanged line-height values that use units (I could not find a good
 unitless solution that would work across all browsers and admin pages)
 {{{
 line 1255 - .edit-attachment-frame .edit-media-header .right:before,
 .edit-attachment-frame .edit-media-header .left:before
 }}}

 Unable to find selectors in the DOM
 {{{
 line 162 - .media-item .progress (couldn't keep it on the page long enough
 to inspect it)
 line 187 - .media-item .progress .percent (same as above)
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46530>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform