[wp-trac] [WordPress Trac] #46526: CSS line-height values should be unitless - buttons.css

[WordPress Trac]

#46526: CSS line-height values should be unitless - buttons.css
-------------------------------------+-------------------------------------
 Reporter:  ianbelanger              |       Owner:  ianbelanger
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  General                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, administration,
  good-first-bug                     |  coding-standards
-------------------------------------+-------------------------------------
Description changed by ianbelanger:

Old description:

> As outlined in #44643, CSS line-height values should be unitless `unless
> necessary to be defined as a specific pixel value`. It was suggested that
> we break up 44643 by stylesheet in order to better track them.
>
> This ticket covers `wp-includes/css/buttons.css`
>
> Note: The patch was tested only on a Windows machine in Chrome, Firefox,
> IE11 and Edge. As per
> https://core.trac.wordpress.org/ticket/44643#comment:23 it should
> probably be tested on other OS's and supported browsers.

New description:

 As outlined in #44643, CSS line-height values should be unitless `unless
 necessary to be defined as a specific pixel value`. It was suggested that
 we break up 44643 by stylesheet in order to better track them.

 This ticket covers much of `wp-includes/css/buttons.css`, see patch notes
 below

 Note: The patch was tested only on a Windows machine in Chrome, Firefox,
 IE11 and Edge. As per
 https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably
 be tested on other OS's and supported browsers.

 **Patch Notes:**

 Unable to find selectors in the DOM. It appears that this particular
 selector no longer exists in core
 {{{
 line 360 - #media-upload.wp-core-ui .button
 }}}

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46526#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform