[wp-trac] [WordPress Trac] #44585: Docs: $wpdb->prepare should point to $wpdb->esc_like method
WordPress Trac
noreply at wordpress.org
Fri Mar 15 10:51:34 UTC 2019
#44585: Docs: $wpdb->prepare should point to $wpdb->esc_like method
-------------------------------------------------+-------------------------
Reporter: felipeelia | Owner: (none)
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: Future
| Release
Component: Database | Version:
Severity: normal | Resolution:
Keywords: good-first-bug has-patch needs- | Focuses: docs
testing |
-------------------------------------------------+-------------------------
Comment (by johannadevos):
It seems that while you guys were working on this ticket, a
[https://core.trac.wordpress.org/ticket/45204 duplicate ticket] was
created. In that ticket (#45204), the first solution as proposed in the
current ticket (#44585) was accepted and implemented in WordPress's code
base. That solution happened to be identical to the first solution in the
current ticket, namely `44585.diff`.
However, @ocean90 has pointed out that this solution is inadequate. As a
result, @mbelchev proposed a second solution (`44585.2.diff`), which is
the one that we want.
Because the inadequate solution has already been implemented in the
WordPress code base in the mean time, the `44585.2.diff` patch no longer
applies. Therefore, a new patch should be created to implement @ocean90's
solution as applied to the current version of the code base.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44585#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list