[wp-trac] [WordPress Trac] #46493: CSS line-height values should be unitless - common.css

[WordPress Trac]

#46493: CSS line-height values should be unitless - common.css
-------------------------------------+-------------------------------------
 Reporter:  ianbelanger              |      Owner:  ianbelanger
     Type:  defect (bug)             |     Status:  assigned
 Priority:  normal                   |  Milestone:  Awaiting Review
Component:  General                  |    Version:
 Severity:  normal                   |   Keywords:  has-patch needs-testing
  Focuses:  ui, administration,      |  good-first-bug
  coding-standards                   |
-------------------------------------+-------------------------------------
 As outlined in #44643, CSS line-height values should be unitless `unless
 necessary to be defined as a specific pixel value`. It was suggested that
 we break up 44643 by stylesheet in order to better track them.

 This ticket covers much of `wp-admin/css/common.css`, see patch notes
 below

 Note: The patch was tested only on a Windows machine in Chrome, Firefox,
 IE11 and Edge. As per
 https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably
 be tested on other OS's and supported browsers

 **Patch Notes:**

 Unchanged line-height values that use units (I could not find a good
 unitless solution that would work across all browsers and admin pages)
 {{{
 line 222 - body
 line 509 - .widefat td, .widefat td p, .widefat td ol, .widefat td ul
 line 516 - .widefat th, .widefat thead td, .widefat tfoot td
 line 759 - .widget .widget-top, .postbox .hndle, .stuffbox .hndle,
 .control-section .accordion-section-title, .sidebar-name, #nav-menu-
 header, #nav-menu-footer, .menu-item-handle, .checkbox, .side-info, #your-
 profile #rich_editing, .widefat thead th, .widefat thead td, .widefat
 tfoot th, .widefat tfoot td
 }}}

 Unable to find these selectors anywhere in the DOM
 {{{
 line 838 - .key-labels label
 line 1739 - .toggle-arrow
 line 1769 - #number-of-columns
 line 3040 - .bulk-action-notice .toggle-indicator:before
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46493>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform