[wp-trac] [WordPress Trac] #41074: Create new Dashicons (4.9)

[WordPress Trac]

#41074: Create new Dashicons (4.9)
-------------------------------------------------+-------------------------
 Reporter:  EmpireOfLight                        |       Owner:  netweb
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.2
Component:  Editor                               |     Version:  4.9
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-dev-note reporter-   |     Focuses:  ui
  feedback                                       |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  needs-refresh has-patch => has-patch needs-dev-note reporter-
     feedback


Comment:

 So I did some investigating. The
 [https://developer.wordpress.org/resource/dashicons/ developer resources
 Dashicons page] uses the Dashicon version shipped in WordPress Core, and
 the font is not stored on the CDN at all. The new icons do, however, need
 to be added manually to the developer resources page after that site is
 updated to 5.2 (or `trunk`, if it runs the latest commit).

 I was having an issue with the most recent patch, so I pulled down the
 Dashicons GIT repo, built the files, and created a new patch (which does
 not include the font file changes).

 Here is the updated list of additions I see reviewing:

 - `.dashicons-admin-site-alt (f11d)`
 - `.dashicons-admin-site-alt2 (f11e)`
 - `.dashicons-admin-site-alt3 (f11f)`
 - `.dashicons-buddicons-activity (f452)`
 - `.dashicons-buddicons-bbpress-logo (f12b)`
 - `.dashicons-buddicons-buddypress-logo (f448)`
 - `.dashicons-buddicons-community (f453)`
 - `.dashicons-buddicons-forums (f449)`
 - `.dashicons-buddicons-friends (f454)`
 - `.dashicons-buddicons-groups (f456)`
 - `.dashicons-buddicons-pm (f457)`
 - `.dashicons-buddicons-replies (f451)`
 - `.dashicons-buddicons-topics (f450)`
 - `.dashicons-buddicons-tracking (f455)`
 - `.dashicons-businessperson (f12e)`
 - `.dashicons-businesswoman (f12f)`
 - `.dashicons-color-picker (f131)`
 - `.dashicons-editor-ltr (f129)`
 - `.dashicons-editor-ol-rtl (f12c)`
 - `.dashicons-email-alt2 (f10a)`
 - `.dashicons-instagram (f12d)`
 - `.dashicons-menu-alt (f10b)`
 - `.dashicons-plus-light (f10c)`
 - `.dashicons-rest-api (f124)`
 - `.dashicons-yes-alt (f12a)`
 - `.dashicons-tide (f10d)`

 Overall this is looking good (pending some Windows testing). There are two
 points I need addressed and this can be committed.

 All the icons appear to be displaying correctly except `.dashicons-
 instagram`. I have uploaded a screenshot of this for review.

 After reading through the ticket, there are a few comments indicating that
 two icons were removed:

 - `.dashicons-plus-alt2 - f543`
 - `.dashicons-share1 - f237`

 It is preferable to not remove icons. Once the icon is bundled and
 released with WordPress, we have to assume it is being used by someone and
 we should maintain that icon. I can't find any indication that
 `dashicions-share1` was ever shipped in Core, but `plus-alt2` was
 (introduced in [33126]). I have not been able to track down where in the
 GIT history this icon was removed, though.

 Question on the `.woff2` file. The `.woff` file will not be updated and
 remain as is, but I think that the `.woff2` file can be introduced for
 anyone that wishes to load it as long as this will continue to be
 maintained (which I think is the intention).

 I am also marking this a `needs-dev-note` so that everyone is aware of the
 new dashicons, and of the changes specified regarding `.woff` files in the
 previous paragraph. Happy to write that up!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41074#comment:86>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform