[wp-trac] [WordPress Trac] #44901: Remove unneeded WP_Error in confirmaction

[WordPress Trac]

#44901: Remove unneeded WP_Error in confirmaction
-----------------------------+------------------------------
 Reporter:  garrett-eclipse  |       Owner:  garrett-eclipse
     Type:  enhancement      |      Status:  accepted
 Priority:  normal           |   Milestone:  5.2
Component:  Privacy          |     Version:  4.9.6
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+------------------------------

Comment (by garrett-eclipse):

 Thanks @birgire I appreciate the thorough testing and feedback.

 I've provided 44901.5.diff to cover your feedback and updated;
 - All instances of 'Invalid key' to 'Invalid key.' with ending period.
 - Updated the error when `$key` is empty to state 'Missing confirm key.'
 which is used in the confirmaction.
 - Updated the die message when `request_id` isn't set on `$_GET` to
 'Missing request ID.'

 Can you give it a once over when you have a chance and we'll move this
 forward.
 Cheers

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44901#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform