[wp-trac] [WordPress Trac] #46313: WordPress 5.1 and $themes backward compatibility break-ish

[WordPress Trac]

#46313: WordPress 5.1 and $themes backward compatibility break-ish
--------------------------+----------------------
 Reporter:  flexithemes   |       Owner:  (none)
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  Themes        |     Version:  5.1
 Severity:  normal        |  Resolution:  wontfix
 Keywords:                |     Focuses:
--------------------------+----------------------

Comment (by earnjam):

 @flexithemes You really should not modify core files like that. Pretty bad
 idea for a number of reasons.

 All you need to do is just change the name of the global variable you are
 using in the theme. You could add some sort of prefix (example:
 `$teva_theme`).

 But the best solution would simply be to not use a global variable at all.
 This is a good example of why they are problematic and generally should be
 avoided if possible.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46313#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform