[wp-trac] [WordPress Trac] #46167: Network update does not create wp_blogmeta table

[WordPress Trac]

#46167: Network update does not create wp_blogmeta table
--------------------------------+------------------------
 Reporter:  waryn               |       Owner:  (none)
     Type:  defect (bug)        |      Status:  reopened
 Priority:  normal              |   Milestone:  5.2
Component:  Networks and Sites  |     Version:  5.1
 Severity:  major               |  Resolution:
 Keywords:  has-patch           |     Focuses:  multisite
--------------------------------+------------------------

Comment (by flixos90):

 Replying to [comment:41 vanyukov]:
 > Both of your solutions add 2 extra queries which will be executed on
 **every** page load to fix an issue that happens **only** on WordPress
 update from 5.0.3 to 5.1

 What do you mean by 2 extra queries? Site meta not being supported is a
 consideration that needs to be accounted for throughout, some sites may
 not run the network update for a long time. Doing one extra check for
 whether the filter already exists doesn't add significant overhead.

 Regarding the approach, I prefer [attachment:"46167.2.diff"] - although a
 direct function call certainly seems more elegant, we introduced those
 filters in #44467 and #45091 to get rid of exactly this. Hooking the
 filter in on the fly helps clarifying to someone reading the code that
 filters should be used here.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46167#comment:42>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform