[wp-trac] [WordPress Trac] #46351: Properly re-fill the `$meta` param of deprecated `wpmu_new_blog` action

WordPress Trac noreply at wordpress.org
Tue Mar 5 15:21:19 UTC 2019


#46351: Properly re-fill the `$meta` param of deprecated `wpmu_new_blog` action
--------------------------------+------------------------
 Reporter:  david.binda         |       Owner:  (none)
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  5.1.1
Component:  Networks and Sites  |     Version:  5.1
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:  multisite
--------------------------------+------------------------

Comment (by david.binda):

 Thanks for the code review and the feedback!

 You're right, a wrong action name was used in the `remove_action` call.
 However, inspecting the `WP_UnitTestCase_Base::__restore_hooks` showed
 that there is no need to remove action/filter set in one test, as the
 method "Restores the hook-related globals to their state at setUp() so
 that future tests aren't affected by hooks set during this last test."

 I've adjusted the patch accordingly (removing the `remove_action` call
 altogether).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46351#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list