[wp-trac] [WordPress Trac] #46280: Uncaught javascript error on comment-reply.js

[WordPress Trac]

#46280: Uncaught javascript error on comment-reply.js
--------------------------+----------------------------
 Reporter:  xknown        |       Owner:  peterwilsoncc
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  5.1.1
Component:  Comments      |     Version:  5.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+----------------------------
Changes (by peterwilsoncc):

 * keywords:  has-patch needs-testing => has-patch


Comment:

 Tested in the following using either real browsers or via BrowserStack.

 I'm happy with putting this in as it works as advertised in recent
 browsers, in older browsers it can use the fall back if a theme or plugin
 modifies the script in an unexpected fashion, ie by forcing it to the HTML
 header.

 **Browser tests**

 pass: script runs and moves comment reply form
 FB pass: fall back pass using replytocom link, no console error

 AJAX loaded, script in header:
 * IE 11 - pass
 * iOS 11 - pass
 * iOS 12 - pass
 * Firefox 65 - pass
 * Chrome 72 - pass
 * Safari 12 - pass
 * Safari 11 - pass
 * Android 8 Chrome - pass
 * Android 7 Chrome - pass
 * Android 6 chrome - pass
 * IE 10 - FB pass
 * IE 9 - FB pass
 * IE 8 - FB pass
 * Safari 5.1 - FB pass

 normally loaded, script in header:
 * IE 11 - pass
 * iOS 11 - pass
 * iOS 12 - pass
 * Firefox 65 - pass
 * Chrome 72 - pass
 * Safari 12 - pass
 * Safari 11 - pass
 * Android 8 Chrome - pass
 * Android 7 Chrome - pass
 * Android 6 chrome - pass
 * IE 10 - FB Pass (readyState browser bug)
 * IE 9 - FB Pass (readyState browser bug)
 * IE 8 - FB pass (readyState incomplete support)
 * Safari 5.1 - pass

 Script in footer, IE as expected
 * As above with IE 9 and 10 passing.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46280#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform