[wp-trac] [WordPress Trac] #43658: Media attachment filter drop-down mime types in grid mode is not properly filtered by available mime types

[WordPress Trac]

#43658: Media attachment filter drop-down mime types in grid mode is not properly
filtered by available mime types
-------------------------------------------------+-------------------------
 Reporter:  itzmekhokan                          |       Owner:
                                                 |  adamsilverstein
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.2
Component:  Media                                |     Version:  4.9.4
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots needs-     |     Focuses:
  testing needs-unit-tests                       |
-------------------------------------------------+-------------------------

Comment (by adamsilverstein):

 Travis was failing (https://travis-ci.org/adamsilverstein/wordpress-
 develop-fork/jobs/500433986) because the linting errors in `wp-
 includes/media.php` could not be fixed automatically.

 I ran `phpcs --standard=phpcs.xml.dist src/wp-includes/media.php` and
 manually addressed all errors. Errors fixed included "Assignments must be
 the first block of code on a line" and "Use Yoda Condition checks, you
 must" as well as "Use placeholders and $wpdb->prepare(); found $sql"

 [attachment:"43658.3.diff"] includes code fixes in response to phpcs

 travis build started: https://travis-ci.org/adamsilverstein/wordpress-
 develop-fork/builds/501627830

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43658#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform