[wp-trac] [WordPress Trac] #46041: Personal data tables: missing headings

[WordPress Trac]

#46041: Personal data tables: missing headings
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  desrosj
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.2
Component:  Privacy                  |     Version:  4.9.6
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  accessibility,
  patch                              |  administration
-------------------------------------+-------------------------------------
Changes (by desrosj):

 * keywords:  has-screenshots has-patch commit => has-screenshots has-patch


Comment:

 I don't like the idea of changing the current screen here as that would be
 a backward compatibility break. Plugins that are relying on `tools_page_*`
 would not know of this change.

 I believe that [attachment:"46041.2.diff"] solves the issue in a backward
 compatible way. It uses the screen object stored in the `WP_List_Table`
 instance to add the screen reader text (where the text is checked) to add
 the text instead of changing the global current page.

 I imagine there are some weird behaviors being caused by these two not
 matching that have not been discovered yet. Unifying these can be tackled
 in #43895.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46041#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform