[wp-trac] [WordPress Trac] #46351: Properly re-fill the `$meta` param of deprecated `wpmu_new_blog` action
WordPress Trac
noreply at wordpress.org
Mon Mar 4 15:47:20 UTC 2019
#46351: Properly re-fill the `$meta` param of deprecated `wpmu_new_blog` action
--------------------------------+------------------------
Reporter: david.binda | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.1.1
Component: Networks and Sites | Version: 5.1
Severity: normal | Resolution:
Keywords: has-patch | Focuses: multisite
--------------------------------+------------------------
Comment (by pbiron):
@davidbinda: the revised patches looks good!
When adding a site interactively, I get the same array passed to my
function hooked to `wpmy_new_blog` as I do in 5.0.3. When I "manually"
call `wpmu_create_blog()` with additional `$meta`, that additional `$meta`
also gets passed the same as it does in 5.0.3.
Something is screwy with my local setup and I can't run unit tests right
now, so I can't test the unit test in your patch. However, visually
inspecting it, in `test_wpmu_new_blog_action_backward_compatible()`,
shouldn't
{{{#!php
remove_action( 'populate_options', array( $this, 'wpmu_new_blog_callback'
), 10 );
}}}
be
{{{#!php
remove_action( 'wpmu_new_blog', array( $this, 'wpmu_new_blog_callback' ),
10 );
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46351#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list