[wp-trac] [WordPress Trac] #33030: Admin menu update/comment count notification accessibility
WordPress Trac
noreply at wordpress.org
Mon Mar 4 14:00:11 UTC 2019
#33030: Admin menu update/comment count notification accessibility
--------------------------------------+--------------------------------
Reporter: afercia | Owner: afercia
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.2
Component: Administration | Version: 4.2
Severity: normal | Resolution:
Keywords: color-contrast has-patch | Focuses: ui, accessibility
--------------------------------------+--------------------------------
Changes (by afercia):
* keywords: color-contrast has-patch needs-refresh => color-contrast has-
patch
Comment:
[attachment:"33030.diff"] addresses only the Comments and Privacy Policy
"bubbles", I'd appreciate some preliminary testing on it. For better
clarity, I'll prepare a separate patch for the Updates (Plugins etc.) as
they're a bit more complicated and overlap with #29022.
- uses the same string for the "Comments in moderation" (also in the
dashboard widget, see screenshot below)
- this simplifies things and allows to dynamically change the strings in
an easier way
- introduces an `updateInModerationText` JS simple function, responsible
to update all the Comments strings
- makes the bubble and their text slightly bigger
- improves the active item bubble contrast by using the menu background
color, pending design feedback
Testing welcome!
Note: the visually hidden text is always updated based on the data from
the Ajax response. Instead, the visible numbers are still updated via the
old method, based on calculations made on data fetched from the markup.
The old method calculation fails in some edge cases and should probably be
reviewed in a separate ticket.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/33030#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list