[wp-trac] [WordPress Trac] #46041: Personal data tables: missing headings
WordPress Trac
noreply at wordpress.org
Sat Mar 2 10:57:10 UTC 2019
#46041: Personal data tables: missing headings
-------------------------------------+-------------------------------------
Reporter: afercia | Owner: desrosj
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.2
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: has-screenshots has- | Focuses: accessibility,
patch needs-refresh | administration
-------------------------------------+-------------------------------------
Changes (by garrett-eclipse):
* keywords: has-screenshots has-patch => has-screenshots has-patch needs-
refresh
Comment:
Thanks @xkon the patch is working nicely and good call with the
'set_current_screen' I'd thought this might be blocked by #43895 but
that's a nice workaround for now.
One minor note; for the `heading_list` can we add 'data' to them both so
they match the naming applied to the rest of the page;
"Export personal list" => "Export personal data list"
"Erase personal list" => "Erase personal data list"
Only other thought/question I had was with 'Export Personal Data' and
'Erase Personal Data' being the page titles should the verbiage for screen
readers use the capital case as well? In @afercia screenshot 'Filter users
list' has users in lowercase but would capital case be more appropriate.
Attached screens of my tests.
Note: to produce the `heading_pagination` text you have to create enough
requests for the pagination to be introduced.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46041#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list