[wp-trac] [WordPress Trac] #47145: Feature Image dialog does not follow the dialog pattern

[WordPress Trac]

#47145: Feature Image dialog does not follow the dialog pattern
-------------------------------------------------+-------------------------
 Reporter:  anevins                              |       Owner:  afercia
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.3
Component:  Administration                       |     Version:
 Severity:  major                                |  Resolution:
 Keywords:  has-screenshots wpcampus-report      |     Focuses:  ui,
  has-patch commit                               |  accessibility
-------------------------------------------------+-------------------------
Changes (by kjellr):

 * keywords:  has-screenshots wpcampus-report has-patch commit needs-design-
     feedback => has-screenshots wpcampus-report has-patch commit


Comment:

 Hi @afercia! We discussed this issue in today's Design meeting:
 https://wordpress.slack.com/archives/C02S78ZAL/p1561572554396000

 It sounds like the reasoning for moving the left sidebar down is to:

 > To better communicate also visually that the h1 title is the first
 content in the modal, I’d like to propose to slightly move down the menu
 in the left sidebar.

 While this does improve upon the problem, I think the root of the visual
 hierarchy issue is that the "Add Media" text in the left column reads more
 as a heading than as an active menu item. We already have styles elsewhere
 in WP-Admin for this sort of active menu item + heading relationship:

 [[Image(https://cldup.com/icwZ_7z7lG-3000x3000.png)]]

 To keep things consistent, I wonder if we might adopt something like that
 here? Here's a mockup for example:

 [[Image(https://cldup.com/thdmSzQ9Ro-3000x3000.png)]]

 This follows our existing patterns and also helps clarify which is the
 heading.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47145#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform