[wp-trac] [WordPress Trac] #42888: Add a "Show" button next to password fields on mobile

[WordPress Trac]

#42888: Add a "Show" button next to password fields on mobile
-------------------------------------+-------------------------------------
 Reporter:  johnbillion              |       Owner:  shadyvb
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.3
Component:  Login and Registration   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  accessibility,
  screenshots has-ux-feedback        |  javascript
-------------------------------------+-------------------------------------
Changes (by afercia):

 * keywords:
     good-first-bug has-patch dev-feedback has-screenshots 2nd-opinion has-
     ux-feedback needs-refresh
     => has-patch has-screenshots has-ux-feedback
 * owner:  Iceable => shadyvb
 * milestone:  Future Release => 5.3


Comment:

 Thanks @shadyvb! I reviewed a bit the patch. In
 [attachment:"42888.3.diff"]:

 - phpcs fixes (indentation, yoda conditions, translators comment)
 - general clean up
 - restored the focus style on the toggle button
 - added styling to the toggle button in the install page
 - removed some wrappers: seems to me they're unnecessary
 - made the "Remember me" label font size bigger


 Question:
 when the field switches to `type=text`, should we add `autocomplete=off`?

 Some testing would be nice :) Please test also the install page, also in
 the responsive view.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42888#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform