[wp-trac] [WordPress Trac] #45165: E2E Tests: Copy the setup and the e2e tests from the Gutenberg repository
WordPress Trac
noreply at wordpress.org
Sat Jun 22 08:28:04 UTC 2019
#45165: E2E Tests: Copy the setup and the e2e tests from the Gutenberg repository
------------------------------+-----------------------------------------
Reporter: youknowriad | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: Future Release
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript, administration
------------------------------+-----------------------------------------
Comment (by herregroen):
Reviewed the code and left a single simple comment on Github. Beyond that
it looks good.
This should warrant a dev-note with a basic explanation regarding Docker
as well as Puppeteer as it's likely there's developers around who've yet
to work with those tools. Especially running Puppeteer with the GUI as
well as a few examples of basic tests would be really helpful there.
Shouldn't be a blocker for merging this though, more of a follow-up. I'd
suggest discussing this in the upcoming core-js chat and, unless there's
further reviews requesting changes, merging this.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45165#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list