[wp-trac] [WordPress Trac] #46006: comment_form() function doesn't call `comment_form_after_fields` action if fields was set to empty array

[WordPress Trac]

#46006: comment_form() function doesn't call `comment_form_after_fields` action if
fields was set to empty array
--------------------------+----------------------
 Reporter:  Guss77        |       Owner:  (none)
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  Comments      |     Version:  4.4.3
 Severity:  normal        |  Resolution:  wontfix
 Keywords:                |     Focuses:
--------------------------+----------------------
Changes (by earnjam):

 * status:  new => closed
 * resolution:   => wontfix
 * milestone:  Awaiting Review =>


Comment:

 Looks like this behavior was broken in [35723], which introduced the
 `comment_form_fields` filter. The fact that that change was 3.5 years ago
 and this is the only report of it being a problem makes me not want to
 adjust the behavior of the hooks at this point.

 The proper way to modify the default comment fields now would be to use
 the `comment_form_fields` filter. If done that way to insert other
 different fields, then the other two hooks would fire. It doesn't make
 sense to fire a `_fields_before` or `_fields_after` hook if there are no
 fields.

 As such, I'm going to close this as a `wontfix`. Feel free to respond if
 you disagree and we can continue the discussion.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46006#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform