[wp-trac] [WordPress Trac] #46946: Site Health: Text adjustment (add a link and remove "we")

[WordPress Trac]

#46946: Site Health: Text adjustment (add a link and remove "we")
------------------------------------------------+---------------------
 Reporter:  birgire                             |       Owner:  (none)
     Type:  enhancement                         |      Status:  new
 Priority:  normal                              |   Milestone:  5.3
Component:  Site Health                         |     Version:  5.2
 Severity:  normal                              |  Resolution:
 Keywords:  site-health has-patch dev-feedback  |     Focuses:
------------------------------------------------+---------------------

Comment (by leogermani):

 I was going to look to the source to see what is often used but
 @tobifjellner already did it, so great!

 I had a quick chat with @nao to get an input from the translators and she
 also said both are fine but that maybe the first option, with the HTML
 inside, looks cleaner.

 I will update the patch with this approach.

 As for the documentation in the Codex suggesting to use `wp_kses`, I have
 an impression that this is a little too much. If we are worried that
 malicious HTML could be inserted by a translation, we would have to filter
 all strings, not only those that have a link, because the malicious code
 could be inserted in any of them.

 I will have a look if that page was already merged to the new Developer
 Handbook and, if not, I will do so and suggest a change to that
 recommendation.

 Thank you all for the inputs.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46946#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform