[wp-trac] [WordPress Trac] #47564: Protect against recursive customizer navigation menu data

[WordPress Trac]

#47564: Protect against recursive customizer navigation menu data
-----------------------------------------+------------------------------
 Reporter:  donpark                      |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  Awaiting Review
Component:  Customize                    |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch reporter-feedback  |     Focuses:
-----------------------------------------+------------------------------
Description changed by dd32:

Old description:

> Recursive data can slip into navigation menu structure but client-script
> currently has no protection against, resulting in browser freezing when
> trying to edit navigation menus.
>
> Attached patch changes `getDepth()` to keep track of parent navigation
> menu item ID to avoid recursion.
>
> NOTE: This issue and patch may need an A12N to test because verifying
> this bug may be difficult and one known site with this problem needs
> access to MC to test with. If you are an A12N, I've created a WPCOM patch
> for testing purpose at D29638-code.

New description:

 Recursive data can slip into navigation menu structure but client-script
 currently has no protection against, resulting in browser freezing when
 trying to edit navigation menus.

 Attached patch changes `getDepth()` to keep track of parent navigation
 menu item ID to avoid recursion.

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47564#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform