[wp-trac] [WordPress Trac] #42888: Add a "Show" button next to password fields on mobile

[WordPress Trac]

#42888: Add a "Show" button next to password fields on mobile
-------------------------------------+-------------------------------------
 Reporter:  johnbillion              |       Owner:  Iceable
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  Future Release
Component:  Login and Registration   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug has-      |     Focuses:  accessibility,
  patch dev-feedback has-            |  javascript
  screenshots 2nd-opinion has-ux-    |
  feedback needs-refresh             |
-------------------------------------+-------------------------------------

Comment (by shadyvb):

 Updated the patch in
 [https://core.trac.wordpress.org/attachment/ticket/42888/42888.2.diff
 42888.2] while also fixing a few issues:
 - Password generation was broken after applying the patch, now fixed
 - Mobile view didn't have proper padding, fixed as per #42853
 - Mobile view had hide/show titles on the button, removed them, keeping
 only the icon
 - There was a bug on clicking cancel in profile page, the password didn't
 clear and that created unexpected behavior

 Tested using Chrome/Safari on macOS, both mobile and desktop views.

 cc @afercia @boemedia can you please retest ?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42888#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform