[wp-trac] [WordPress Trac] #46910: Allow wp_die to called after html has started output
WordPress Trac
noreply at wordpress.org
Thu Jun 20 12:23:59 UTC 2019
#46910: Allow wp_die to called after html has started output
----------------------------------+-----------------------------
Reporter: spacedmonkey | Owner: SergeyBiryukov
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 5.3
Component: Bootstrap/Load | Version: 5.2
Severity: normal | Resolution:
Keywords: servehappy has-patch | Focuses:
----------------------------------+-----------------------------
Comment (by dimadin):
I have reviewed this patch and here is what I found:
- First check doesn't work on frontend until second `&&` (before `!
did_action( 'wp_head' )`) is not replaced with `||`.
- when you use `wp_die()` on `wp_head`, there is no any styling as you
don't get CSS styles anymore.
- `wp_body_open` check will fail on most themes.
- Any reason why wrapper for error message is part of this?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46910#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list