[wp-trac] [WordPress Trac] #41545: Allow cmd/ctrl-enter to submit comment forms
WordPress Trac
noreply at wordpress.org
Thu Jun 20 09:23:42 UTC 2019
#41545: Allow cmd/ctrl-enter to submit comment forms
-------------------------------------------------+-------------------------
Reporter: helen | Owner:
| adamsilverstein
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.3
Component: Comments | Version:
Severity: minor | Resolution:
Keywords: good-first-bug needs-testing has- | Focuses: javascript
patch needs-refresh |
-------------------------------------------------+-------------------------
Comment (by splitti):
I tested the patch and noticed that the {{{e.metaKey}}} is not set for Cmd
in the {{{keyup}}} events, but {{{keydown}}} works. Even though this might
fire more than once, the click event should be processed first and that
will submit the form. I don't think switching to keydown is a problem, but
will enable Cmd for submitting as is desired in this ticket.
If we want to just enable Ctrl + Enter then I'd be happy to rescind my
updated diff and I'd say we're ready to land this patch.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41545#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list