[wp-trac] [WordPress Trac] #46750: Twenty Nineteen: Add styles to support the group block

[WordPress Trac]

#46750: Twenty Nineteen: Add styles to support the group block
---------------------------------------+---------------------
 Reporter:  kjellr                     |       Owner:  (none)
     Type:  enhancement                |      Status:  new
 Priority:  normal                     |   Milestone:  5.3
Component:  Bundled Theme              |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:
---------------------------------------+---------------------

Comment (by kjellr):

 Excellent testing, @dianeco. Thank you for being so thorough.
 [attachment:"46750.2.patch"] should take care of all those issues.

 > 1. By default Core Gutenberg set the margin top and bottom to 0 when a
 background is set. This propery is overridden by Twenty Nineteen style.

 ✅ Fixed!

 > 2. In the patch the following line make the content touch the top and
 bottom edges:

 ✅ Fixed!

 > 3. Not sure of the utility of these lines which impact column inside
 columns and break their vertical alignment:

 You're right, these aren't needed here. They were originally bundled in
 with the inherited `entry-content`/`entry-summary` styles I pulled in for
 the block.

 ✅ I've broken them out separately in the updated patch, so they are no
 longer applied when they don't need to be.

 > 4. Finally the following lines which are inserted in this patch, but not
 related to group, break the image inside columns:

 Ah yes. That was a bug that I had to fix so that I didn't reproduce it
 inside of the Group block too. Basically — standard-aligned images were
 previously not appearing at the correct width on the front end at all. 😄

 ✅ Good catch on the issue within columns. I've included a little fix for
 that too now.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46750#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform