[wp-trac] [WordPress Trac] #47524: Predefined value of param is wrong in \Walker_Nav_Menu::start_lvl

WordPress Trac noreply at wordpress.org
Fri Jun 14 11:24:59 UTC 2019


#47524: Predefined value of param is wrong in \Walker_Nav_Menu::start_lvl
--------------------------+-----------------------------
 Reporter:  trasweb       |       Owner:  SergeyBiryukov
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  5.3
Component:  Menus         |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  docs
--------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Initially I thought changing this would cause "Declaration must be
 compatible" errors in PHP 7+, but apparently this only happens when
 removing parameters in subclasses or making them required. In my testing,
 changing default parameter type is fine.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47524#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list