[wp-trac] [WordPress Trac] #46957: Site Health: Make site health page access be filterable

[WordPress Trac]

#46957: Site Health: Make site health page access be filterable
--------------------------------------------------+-----------------------
 Reporter:  Clorith                               |       Owner:  Clorith
     Type:  task (blessed)                        |      Status:  assigned
 Priority:  normal                                |   Milestone:  5.2.2
Component:  Administration                        |     Version:  5.2
 Severity:  normal                                |  Resolution:
 Keywords:  site-health has-patch has-unit-tests  |     Focuses:
--------------------------------------------------+-----------------------

Comment (by peterwilsoncc):

 In [attachment:"46957.5.diff"]:

 * Converts final four checks to `view_site_health_checks`
 * Single site install: Ensures only administrators have above capability
 * Multisite install: Ensures only super-admins have above capability
 * Makes coding standards changes to capability test file required for
 formatting test to pass

 That final point adds a lot of white space changes, to view the patch
 without white space [https://github.com/WordPress/wordpress-
 develop/pull/67/files?w=1 view the pull request on GitHub with white space
 changes suppressed].

 [https://travis-ci.com/WordPress/wordpress-develop/builds/114851084
 Witness the tests passing] on Travis CI.

 **Next steps:**

 I had to make rather more changes to the refresh than I expected to get
 the tests passing. So could someone on this ticket/the site health project
 please do the following within the next 24 hours so I can commit it:

 * confirm the patch behaves as expected on a Multisite install
 * confirm the patch behaves as expected on a Single site install
 * add the `commit` keyword and ping me on the ticket if you give it the
 thumbs up.

 I have done the first two but code reviews and logic checks are some of my
 favourite things.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46957#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform