[wp-trac] [WordPress Trac] #44354: Improve `WP_Privacy_Requests_Table` to manage columns
WordPress Trac
noreply at wordpress.org
Fri Jun 7 22:31:19 UTC 2019
#44354: Improve `WP_Privacy_Requests_Table` to manage columns
-------------------------------------------------+-------------------------
Reporter: 7studio | Owner: garrett-
| eclipse
Type: enhancement | Status: assigned
Priority: normal | Milestone: Future
| Release
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: has-patch needs-refresh needs- | Focuses:
testing | administration
-------------------------------------------------+-------------------------
Comment (by pbiron):
Replying to [comment:2 birgire]:
> It's interesting to see the mismatch regarding the output of column
methods in various list tables.
>
> It's both echo and return, but from the
{{{WP_List_Table::single_row_columns()}}} it seems to expect return:
Yeah, `single_row_columns()` appears to expect a value, which implies that
we should use a `filter` instead of an `action` (as in the example from
`WP_Terms_List_Table` mentioned by [comment:6 garrett-eclipse]).
However, of the 11 core list tables that currently support custom columns,
only 2 of them use a `filter` and return a value (`WP_Users_List_Table` is
the other one). You can see that by searching the Code Reference for
[[https://developer.wordpress.org/?s=custom_column&post_type%5B%5D=wp-
parser-hook|hooks that use "custom_column"]].
So, my vote is to go with `action`, as it is more prevalent in core
already.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44354#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list