[wp-trac] [WordPress Trac] #47321: Show different fatal error message when in Recovery Mode and unable to redirect

[WordPress Trac]

#47321: Show different fatal error message when in Recovery Mode and unable to
redirect
-------------------------------------------------+-------------------------
 Reporter:  TimothyBlynJacobs                    |       Owner:  marybaum
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.2.2
Component:  Bootstrap/Load                       |     Version:  5.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch servehappy needs-testing   |     Focuses:
  needs-unit-tests                               |
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch servehappy commit => has-patch servehappy needs-
     testing needs-unit-tests


Comment:

 Replying to [comment:10 marybaum]:
 > Suggested copy:
 >
 > “You’re in recovery mode, but for some reason we are unable to redirect
 you. This may mean there are several errors. Please contact your site
 admin, your developer or the WordPress support forums.”

 I've refreshed the patch in
 [https://core.trac.wordpress.org/attachment/ticket/47321/47321.3.diff
 47321.3.diff] to include @marybaum's suggested copy. Thanks
 @TimothyBlynJacobs & @mukesh27 for the initial patches.

 Minor question: What's the policy on fancy quote in core? `You’re`

 Also should the two other strings found in the
 `display_default_error_template` function get some copy love as well to
 match the tone and conveyance of this string? They are;
 {{{#!php
 } elseif ( is_protected_endpoint() ) {
         $message = __( 'The site is experiencing technical difficulties.
 Please check your site admin email inbox for instructions.' );
 } else {
         $message = __( 'The site is experiencing technical difficulties.'
 );
 }
 }}}

 Also adding 'needs-unit-tests' to account for @afragen's request;
 `Adding a simple test case for triggering these errors and testing the
 patch would be very helpful.`

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47321#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform