[wp-trac] [WordPress Trac] #47488: add "extensibility" to WP_Privacy_Requests_Table

WordPress Trac noreply at wordpress.org
Thu Jun 6 16:50:02 UTC 2019


#47488: add "extensibility" to WP_Privacy_Requests_Table
-------------------------+------------------------------
 Reporter:  pbiron       |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Privacy      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  needs-patch  |     Focuses:
-------------------------+------------------------------

Comment (by pbiron):

 While working on the patch for this, I noticed the following.

 Other core list tables that have a `get_views()` method do **not** output
 a view if the count for that view is 0, e.g., `WP_Posts_List_Table`
 doesn't output "Pending (0)" if there are no posts with `$post_status ===
 'pending').

 However, `WP_Privacy_Requests_Table` does output "Pending (0)" if there
 are no pending requests.

 For consistency's sake, I think `WP_Privacy_Requests_Table` should skip
 views with count of 0.

 Should I open another ticket for that?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47488#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list