[wp-trac] [WordPress Trac] #45605: REST API: Avoid DB queries from generating sample permalink when possible

WordPress Trac noreply at wordpress.org
Sun Jun 2 17:01:04 UTC 2019


#45605: REST API: Avoid DB queries from generating sample permalink when possible
--------------------------------------+-----------------------
 Reporter:  dlh                       |       Owner:  dlh
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  5.3
Component:  REST API                  |     Version:  5.0
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-----------------------
Changes (by dlh):

 * keywords:  has-patch => has-patch has-unit-tests


Comment:

 I've refreshed the two patches, and they should be ready for review. As
 with before, I've kept the patches separate as they can be seen as
 addressing different concerns.

 In [attachment:"45605.3.diff"]: Generate a sample permalink only when a
 field that depends on it is requested.

 In [attachment:"45605.4.diff"]: In
 `WP_REST_Controller::get_fields_for_response()`, exclude fields that
 specify a different context than the request context.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45605#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list